I've implemented modbus client request/responses 1-6,15,16#4
Open
behrat wants to merge 4 commits intoTooTallNate:masterfrom
Open
I've implemented modbus client request/responses 1-6,15,16#4behrat wants to merge 4 commits intoTooTallNate:masterfrom
behrat wants to merge 4 commits intoTooTallNate:masterfrom
Conversation
Author
|
Hi amechti, Here's what I'm using in some of my code: The starting address is 16 in this example, the values are in the array, and the quantity is determined by the array length. |
Owner
There was a problem hiding this comment.
You're not assigning the result of map() to anything here!
|
I'm really sorry to be late for my response. |
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device I'm currently working with only supports functions 1,2,5,15,16, so the others are untested. The code should be the other functions should be very similar, but still... untested. The device also only has a single coil to test with.
Thanks for your previous work. Hopefully you can push this to the npm repository. :)
-Braden