Skip to content

prevent crash if master calls a invalid / unknown function#6

Open
flottokarotto wants to merge 5 commits intoTooTallNate:masterfrom
flottokarotto:master
Open

prevent crash if master calls a invalid / unknown function#6
flottokarotto wants to merge 5 commits intoTooTallNate:masterfrom
flottokarotto:master

Conversation

@flottokarotto
Copy link

No description provided.

@TooTallNate
Copy link
Owner

You should probably just add your own error event handler to prevent the uncaught exception from happening.

@flottokarotto
Copy link
Author

Hi, it was about May i was working with your stack, so i'dont exactly remember why i did not simply add a exception handler.
But i think there was not enouugh information in the error object, because a correct modbus slave have to inform the master that he does not implement the requestet method.

I'm not a javascript expert, so my sultion is probably not the best one, but i think the stack should not simply crash if a unkown function code was called.

thank you for your nice software, it was very usefull for protoyping. Unfortunately i can't use javascript for my production solution :( .

Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants