Skip to content

Only set timezone for valid dates in constructor #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only set timezone for valid dates in constructor #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,12 +578,14 @@ function Date (year, month, day, hour, minute, second, millisecond, timezone) {
case 7:
d = new _Date(year, month, day, hour, minute, second, millisecond); break;
}
if (timezone) {
// set time given timezone relative to the currently set local time
// (changing the internal "time" milliseconds value unless ms specified)
d.setTimezone(timezone, !(argc == 1 && typeof year === 'number'));
} else {
d.setTimezone(exports.currentTimezone);
if (!isNaN(d)) {
if (timezone) {
// set time given timezone relative to the currently set local time
// (changing the internal "time" milliseconds value unless ms specified)
d.setTimezone(timezone, !(argc == 1 && typeof year === 'number'));
} else {
d.setTimezone(exports.currentTimezone);
}
}
return d;
}
Expand Down