Upgrade to NixOS 25.11 #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoggr
force-pushed
the
nixos-25-11-upgrade
branch
from
5e2f340 to
ac03a6b
Compare
jmoggr
force-pushed
the
nixos-25-11-upgrade
branch
from
ac03a6b to
3de4758
Compare
jmoggr
force-pushed
the
nixos-25-11-upgrade
branch
from
3de4758 to
c3952df
Compare
jmoggr
force-pushed
the
nixos-25-11-upgrade
branch
from
c3952df to
e2de152
Compare
jmoggr
commented
Jan 7, 2026
| # wasm-pack needs a writeable $HOME | ||
| # https://github.com/ipetkov/crane/issues/362 | ||
| HOME=$(mktemp -d) npm run build:node | ||
| ''; |
Collaborator
Author
There was a problem hiding this comment.
I don't love how this is duplicated, however #875 should remove the need for a Nix package for notebook-types.
Member
There was a problem hiding this comment.
Agreed. Since we've got a near-term plan that will eliminate the duplication, we don't have to sweat it right now.
jmoggr
commented
Jan 7, 2026
epatters
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade went very smoothly and took ~15min outside of unearthed issues with
wasm-pack.We are using
wasm-packto build thenotebook-typesandcatlogpackages, andwasm-packexpects to find version ofwasm-bindgen-cliin the environment that matches the Cargo version ofwasm-bindgenused by the package being built. It appears that coincidentally this has always been true, up until now. Note: outside of Nixwasm-packwill download the necessarywasm-bindgen.This is very similar to the issue of the npm biome version not matching the nix version. The workaround employed there was to just use a biome version that matches whatever version of biome is used by nixpkgs-unstable. This is not really feasible for a critical library like
wasm-bindgen.It's pretty straight forward to build the build
wasm-bindgen-clifrom source using a helper function fromnixpkgs. The downside of doing this is that we now need to update multiple Nix hashes whenever we upgradewasm-bindgen, and that the version needs to be manually kept in sync between Nix and Cargo. I think that this is acceptable given that we don't frequently upgradewasm-bindgen, and that this pattern should hopefully not apply to much more of our tooling.I'm using an overlay in Nix to set the specific version of
wasm-bindgen-cli, this is basically just inheritance for nixpkgs. The alternative is passing around our own copy ofwasm-bindgen-cliin Nix, but in my experience I've found that to be more error prone and tedious.If we like this pattern, it might make sense to apply it to biome as well.