Skip to content

fix: remove any of events #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jilanglois wants to merge 1 commit into from
Closed

fix: remove any of events #186

jilanglois wants to merge 1 commit into from

Conversation

@jilanglois
Copy link
Contributor

@jilanglois jilanglois commented Nov 7, 2025 •
edited
Loading

Only one option should be shown for events API

@jilanglois jilanglois requested a review from a team as a code owner November 7, 2025 17:28
@jbergstroem
Copy link
Contributor

jbergstroem commented Nov 7, 2025

Only one option should be shown for events API

Is this really correct? an api request can contain many or one of these

@jilanglois
Copy link
Contributor Author

jilanglois commented Nov 7, 2025 •
edited
Loading

Only one option should be shown for events API

Is this really correct? an api request can contain many or one of these

Captura de pantalla 2025-11-07 a la(s) 2 50 13 p  m

I don't think the any of property is achieving the desired result in the docs. The message is that at least one field must be an item. With the any of property we are seeing four practically identical options in the options header.

@jbergstroem
Copy link
Contributor

jbergstroem commented Nov 10, 2025 •
edited
Loading

Only one option should be shown for events API

Is this really correct? an api request can contain many or one of these

Captura de pantalla 2025-11-07 a la(s) 2 50 13 p  m I don't think the any of property is achieving the desired result in the docs. The message is that at least one field must be an item. With the any of property we are seeing four practically identical options in the options header.

I see – I can take a stab at fixing the layout.

@jbergstroem
Copy link
Contributor

jbergstroem commented Nov 10, 2025

Only one option should be shown for events API

Is this really correct? an api request can contain many or one of these

Captura de pantalla 2025-11-07 a la(s) 2 50 13 p  m I don't think the any of property is achieving the desired result in the docs. The message is that at least one field must be an item. With the any of property we are seeing four practically identical options in the options header.

I see – I can take a stab at fixing the layout.

The problem isn't the anyOf, just how we format the underlying objects. I will do something similar to how we handle auctions and open a PR for review.

@jbergstroem jbergstroem mentioned this pull request Nov 10, 2025
Merged
@jilanglois
Copy link
Contributor Author

jilanglois commented Nov 10, 2025

Closing this PR because #187 fixes the issue.

@jilanglois jilanglois closed this Nov 10, 2025
jbergstroem added a commit that referenced this pull request Nov 10, 2025
@jbergstroem
chore: improve Event property
d2c1cd4 
- merge `anyOf` and properties for the Event schema
- add a maxItems to auctions array and use discriminator to explain the type relationship
- CategoryDisjunctions incorrectly refers to `minimum` instead of using `minLength`

PR: #187
Closes: #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celzo celzo celzo approved these changes

@jbergstroem jbergstroem Awaiting requested review from jbergstroem

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jilanglois @jbergstroem @celzo