Skip to content

fix: eventsRequest needs to contain more than one property #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbergstroem merged 1 commit into from
Nov 13, 2025
Merged

fix: eventsRequest needs to contain more than one property #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions topsort-api-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,44 +84,44 @@
- results
examples:
- results:
- winners:
- rank: 1
type: product
id: p_Mfk11
resolvedBidId: WyJiX01mazExIiwiMTJhNTU4MjgtOGVhZC00Mjk5LTMyNjYtY2ViYjAwMmEwZmE4IiwibGlzdGluZ3MiLCJkZWZhdWx0IiwiIl0==
campaignId: 82588593-85c5-47c0-b125-07e315b7f2b3
error: false

Check warning on line 93 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: `0` property tag "resultType" must be string.
- winners:
- rank: 1
type: product
id: p_Mfk15
resolvedBidId: WyJiX01mazE1IiwiMTJhNTU4MjgtOGVhZC00Mjk5LTgzMjctY2ViYjAwMmEwZmE4IiwibGlzdGluZ3MiLCJkZWZhdWx0IiwiIl0=
campaignId: 4bcc6093-f367-4df2-aa1b-7c1674dd6441
- rank: 2
type: product
id: p_PJbnN
resolvedBidId: WyJlX1BKYm5OIiwiMTJhNTU4MjgtOGVhZC00Mjk5LTgzMjctY2ViYjAwMmEwZmE4IiwibGlzdGluZ3MiLCJkZWZhdWx0IiwiIl0=
campaignId: a72e4e43-55b5-4d08-81bb-cbb57df59c72
error: false

Check warning on line 105 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: `1` property tag "resultType" must be string.
- winners:
- rank: 1
type: product
id: p_PJbnN
resolvedBidId: WyJlX1BKYm5OIiwiMTJhNTU4MjgtOGVhZC00Mjk5LTgzMjctY2ViYjAwMmEwZmE4IiwiYmFubmVyQWRzIiwiZGVmYXVsdCIsIiJd
campaignId: 1156ef4e-0109-4190-ac97-4436c82358d2
asset:
- url: https://topsort.cdnprovider.com/lhs-banner-image-for-p_PJbnN-1x.png
content:
headingText:
"A banner for Topsort with a product image and a shop now button"
bannerText: "Topsort has the best tech!"
bannerTextColour: "48a94c"
heroImage: "https://assets.imageurl.io/s/85d2d333-eed5-44d7-b131-8851d59f0574"
heroImageAltText: "Topsort product image"
error: false

Check warning on line 121 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: `2` property tag "resultType" must be string.
- results:
- winners: []
error: false

Check warning on line 124 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: `0` property tag "resultType" must be string.
"400":
$ref: "#/components/responses/BadRequest"
"401":
Expand Down Expand Up @@ -584,8 +584,8 @@
minLength: 1
minItems: 1
examples:
- c_men_clothing

Check warning on line 587 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: type must be array.
- c_shoes

Check warning on line 588 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: type must be array.
- type: object
title: Category Disjunctions
description: Multiple disjunctions of categories for the purpose of running an auction.
Expand All @@ -605,8 +605,8 @@
minItems: 1
maxItems: 5
examples:
- c_red

Check warning on line 608 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: type must be array.
- c_blue

Check warning on line 609 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-invalid-schema-examples 

Example value must conform to the schema: type must be array.
SingleCategory:
type: object
title: Single Category
Expand Down Expand Up @@ -1943,6 +1943,7 @@
EventsRequest:
type: object
additionalProperties: false
minProperties: 1
properties:
impressions:
title: Impressions
Expand Down
Loading