Skip to content

Conversation

@jbergstroem
Copy link
Contributor

@jbergstroem jbergstroem commented Dec 7, 2025

This was introduced during my refactor. Correct or not (our ci suite had no issue), Mintlify didn't have an issue up top a few days ago.

Note: I updated our public docs repo to make sure our clients can use this before it lands.

We keep it in the outer boundary
@jbergstroem jbergstroem requested a review from a team as a code owner December 7, 2025 21:20
@jbergstroem jbergstroem requested review from celzo and sk- December 7, 2025 21:20
@jbergstroem jbergstroem changed the title fix: remove min/maxItems from type fix: remove min/maxItems from AuctionRequest component Dec 7, 2025
Copy link
Contributor

@sk- sk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are removing it because mintlify's open api support is limited, then we should at least document it in the description of the fields.

@jbergstroem
Copy link
Contributor Author

jbergstroem commented Dec 9, 2025

If we are removing it because mintlify's open api support is limited, then we should at least document it in the description of the fields.

It still works -- I patched it manually (openapi/v2.yml) and it works as intended: https://api.docs.topsort.com/api-reference/auctions/create-auctions#body-auctions

@jbergstroem jbergstroem requested a review from sk- December 10, 2025 08:42
@jbergstroem jbergstroem merged commit d1af9f0 into main Dec 11, 2025
6 checks passed
@jbergstroem jbergstroem deleted the fix/discriminator-auctions branch December 11, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants