chore: fix some linting issues #194
Open
+26
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this Pr we address some of the issues detected by the same vacuu config we are using for our other API spec. In particular, we: - add missing description to /auctions/sponsored-brand - remove EptyAuctionResult as this was not necessary - specify the resultType in AuctionResult schemas, this fixes all the invalid examples
Contributor
Author
|
@rodrhern-topsort please take a look |
rodrhern-topsort
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Pr we address some of the issues detected by the same vacuu config we are using for our other API spec.
In particular, we:
Note
Streamlines and validates the OpenAPI spec with stricter discriminators and cleanup.
EmptyAuctionResultschema and its references fromAuctionResultandTravelAuctionResultmappingsresultTypeconstvalues inBannersAuctionResult,SponsoredListingsAuctionResult,HotelsAuctionResult, andFlightsAuctionResultHotelsAuctionResultexplicitly (instead of referencing listings result)typefields toconst(hotels,flights) instead of single-value enums/v2/auctions/sponsored-brandendpointWritten by Cursor Bugbot for commit fa49c70. This will update automatically on new commits. Configure here.