Skip to content

Conversation

@jbergstroem
Copy link
Contributor

Changed the logic to validate and throw if all three params are passed. This makes assumptions but at least stops the user from doing things that the server will fail either way.

Note: used claude to write tests

@jbergstroem jbergstroem requested a review from anonvt October 23, 2025 21:55
Copy link
Contributor

@anonvt anonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with this approach is if someone just version bumps their app and continue to fail silently because they're not handling errors properly/are too lax (the customer using this didn't pick up on the 400s so they might not pick up on this as well)

@jbergstroem
Copy link
Contributor Author

jbergstroem commented Oct 23, 2025

My concern with this approach is if someone just version bumps their app and continue to fail silently because they're not handling errors properly/are too lax (the customer using this didn't pick up on the 400s so they might not pick up on this as well)

How is the outcome different tho? No ads returned.

@anonvt
Copy link
Contributor

anonvt commented Oct 23, 2025

I've combined your runtime check with the safe typing of the previous PR #176

How is the outcome different tho? No ads returned.

I expect to break in compile time when they version bump so they actually fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants