Skip to content

Conversation

@eobrain
Copy link

@eobrain eobrain commented May 31, 2012

Fix bug that was preventing printing of PDF. I changed an "=" to "=="
in the delayedPrintPageLoadComplete() function in the mininav.js file.

@Torisugari
Copy link
Owner

Fix bug that was preventing printing of PDF. I changed an "=" to "=="

Good catch! Or should I say I'm stupid...

-noheadfoot

Hmm.

If we don't want to switch on/off frequently, probably we should use user pref instead of command line so as to keep our typing lean and mean.

If a lot of people like to kill header/footer only on outputting to a PDF file, maybe I should bundle a custom printer setting under /default/preferences/, say, "cmdlnprintPDF.js". In the first place, these settings are the reason why I added -printprinter, but it seems too troublesome for users...

eobrain-2

According to the version parser, "-" is one of the special characters, which means "minus", not "hyphen" nor other separators.
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsVersionComparator.cpp

Thank you very much.

@eobrain
Copy link
Author

eobrain commented Jun 1, 2012

Hi. Glad to help.

I was really only offering the bugfix commit b76ccb6 as a pull request.

The -noheadfoot change is something that is convenient for me in a headless cloud configuration environment. I understand this may not be the cleanest way to do it. so I do not necessarily expect you to pull this change into your main code. I might try your code sometime in the future, so I can abandon my fork.

Thanks for pointing out that the version parser does not like "-". I was only using it for my own local convenience to avoid getting mixed up between your XPI and my forked XPI. I am not sure what the versioning convention is for private branches and forks. I'll take out the "-".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants