feat: Update scriptform.simba to auto-add/save/track last used account #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed account Big change to scriptform.simba. Many users start scripts without clicking add account or update account and scripts will not login or relog because of it. This change will recognize when any of the 4 inputs where a user types has a change and will dynamically write those changes to the credentials.simba file. If a username is new/unique, a new account is automatically added and the selected account in the current account dropdown is automatically updated. If the username stays the same, but other details such as worlds has been updated, only the changed information is updated for the already existing account. Metadata in the form of "// lastUsed=prosimbauser" is written to the credentials file and is also dynamically updated so that simba will remember the last account used and will load that account information on the next script start. While not necessary, the Add Account and Update Account buttons still exist and their functionality is preserved for those with the muscle memory to use them. Tested on several scripts including those with per-account settings without issue.
Baconadors
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big change to scriptform.simba. Many users start scripts without clicking add account or update account and scripts will not login or relog because of it.
This change will recognize when any of the 4 inputs where a user types has a change and will dynamically write those changes to the credentials.simba file. If a username is new/unique, a new account is automatically added and the selected account in the current account dropdown is automatically updated. If the username stays the same, but other details such as worlds has been updated, only the changed information is updated for the already existing account.
Metadata in the form of "// lastUsed=prosimbauser" is written to the credentials file and is also dynamically updated so that simba will remember the last account used and will load that account information on the next script start.
While not necessary, the Add Account and Update Account buttons still exist and their functionality is preserved for those with the muscle memory to use them.
Tested on several scripts including those with per-account settings without issue.