New feature: Allows use of two different auxiliary LED colors between simple and advanced modes#130
Open
k4n3d4-sh0t4r0 wants to merge 2 commits intoToyKeeper:trunkfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm proposing a new option for users, I think it's a good idea to be able to change the auxiliary colors in simple mode independently of advanced mode and vice versa. This makes it possible to use two different auxiliary LED colors between simple and advanced mode. It could be useful to know which mode you're in, as there's no way to tell them apart at a glance.
What I've done works, but I have no idea if it's the best option for implementing this modification.
I don't know how to do it, but if you think it's a good idea, what would be great would be to be able to activate or deactivate this option directly with settings shortcuts like in misc config, for example.