Manual: Clarify turbo style momentary turbo#157
Open
dirtydancing wants to merge 1 commit intoToyKeeper:trunkfrom
Open
Manual: Clarify turbo style momentary turbo#157dirtydancing wants to merge 1 commit intoToyKeeper:trunkfrom
dirtydancing wants to merge 1 commit intoToyKeeper:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding the turbo style configuration, at present, the manual is somewhat unclear when stating "This value also affects momentary turbo in Ramp and Off modes."
This comes in the same line right after Anduril 2 style and could be understood to refer to this specific Anduril 2 turbo style setting only. If I am not mistaken, of the three turbo style options, Anduril 1 style and Anduril 2 style will go momentary turbo, whereas "No turbo, only ceiling" will go to momentary ceiling (this topic came up together with the turbo styles recently over at BLF, see this BLF post of mine).
So first, this is to clarify that the "This value ..." sentence refers to the turbo styles in general, not only to Anduril 2 turbo style; this is done by adding two spaces at the end of the previous line, so this sentence starts in a new line.
And second, this is to specify what this sentence means, i.e. what deviates from momentary turbo; this is done by adding "If
0: No turbo, only ceiling.is selected, there will also be no momentary turbo, only momentary ceiling."