Pull Request Challenge Joao Alvares Neto #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MVVM Architecture - Kodein Implementation - Picasso Implementation - Retrofit and Rx implementation - webservice calling API - Responses treatment TODO - Fix bug when rotating and loading images (calling the api several times) - rename classes - fix return to same item in the previous activity - fix typos and bad codes - animation and test?
-delete class MyTransformer - refactory -extension visibility -delete PhotoDetails - refactory -refactory DetailsActivity -Delete bind Mytransformer Kodein -change notifydataSet to NotifiyItemRange -few classes renames
-code typos and improvements - current position list - listener scroll fix - "cache" original list
- layout changes - code improvements
- test implementation (not functional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project made with
Kotlin
Kodein DI
Retrofit
Rx
Picasso
MVVM
Tests - Espresso
Didn't focus on layout trying to get the most of the tools presented above.