Fix error in game saving code#42
Open
dmitry-brizhinev wants to merge 1 commit intoTriang3l:masterfrom
Open
Conversation
This error prevents values of type ev_entity from being saved. I saw this manifest as a reproducible crash with Scourge of Armagon, caused by the persistent-bullet-holes code: 1. Start a new game of Scourge of Armagon 2. Walk up to a wall and shoot the shotgun at it more than 10 times (when the bullet holes start disappearing) 3. Save the game 4. Load the game 5. Shoot the shotgun again -> crash with "bullethole == nullentity"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error prevents values of type ev_entity from being saved.
I saw this manifest as a reproducible crash with Scourge of Armagon, caused by the persistent-bullet-holes code: