Automate GH JAR Upload to DevOps #24
Conversation
tsweckard
changed the title
.github/workflows/build.yml
Outdated
| git add resources/ | ||
| git commit -m "Update GraphHopper JAR from GitHub build - ${{ steps.jar-info.outputs.date }}" \ | ||
| -m "Built from commit: ${{ github.sha }}" \ | ||
| -m "Java version: 25" |
There was a problem hiding this comment.
question: sometimes when we merge from GH main, the Java version is updated. How were you thinking about handling that?
There was a problem hiding this comment.
I don't see a good way of dynamically updating this. I thought we could read it from a pom.xml file but it's only being updated in this build yml so we'll have to ensure that when we merge main, we update the values in this pipeline.
There was a problem hiding this comment.
I think we'll want some sort of documentation in order to store these steps so that we don't need to remember all of the processes. Then we can update the values as we're merging in main.
Since we're likely not merging our fork back in, what are your thoughts on adding some documentation in this repo? @payneBrandon
There was a problem hiding this comment.
Is that just needed to run the JAR file in our VM? It'd be fine to add in some documentation to it I think
There was a problem hiding this comment.
I think some documentation on keeping this build.yml updated, how to keep the secrets updated, and briefly how it works. Since we're updating it to build the jar automatically, we don't need to document how to compile and build it as much.
chansbtran
left a comment
chansbtran
left a comment
There was a problem hiding this comment.
LGTM! Just an open comment for Brandon regarding documentation.
payneBrandon
left a comment
payneBrandon
left a comment
There was a problem hiding this comment.
just a couple questions, all makes sense to me so far!
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… us/17033-azure-gh-pipeline
Our current workflow after PR 21 get's merged requires manually downloading the JAR file built from the build pipeline, creating a new branch in the DevOps GraphHopper repository, copying the JAR over and submitting a PR.
This updates our build pipeline to do all of this for us by accessing the Azure DevOps repo, copying the built JAR and creating a PR with Chan and I as reviewers.