Skip to content

Conversation

@payneBrandon
Copy link
Contributor

This pull request migrates the project from Create React App to Vite, modernizing the build tooling, updating environment variable usage, and making related code and documentation changes. The most important changes include switching to Vite for development and build scripts, updating environment variable references throughout the codebase, and adding Vite-specific configuration and documentation.

Migration to Vite:

  • Updated package.json to remove Create React App dependencies and scripts, add Vite dependencies and scripts, and set "type": "module" for ES module support.
  • Added vite.config.ts with Vite configuration, including plugin setup, server options, build output, and environment variable definitions.

Environment variable changes:

  • Replaced all references to process.env.REACT_APP_API_KEY and process.env.REACT_APP_URL with import.meta.env.VITE_API_KEY and import.meta.env.VITE_URL in src/App.tsx for API key and URL usage. [1] [2] [3] [4]
  • Updated the documentation in README.md to instruct users to use VITE_API_KEY and VITE_URL instead of the previous environment variable names.

Project structure and code improvements:

  • Added a new index.html file for Vite, replacing the Create React App HTML entry point.
  • Improved React list rendering in src/App.tsx by adding key props to radio button groups to avoid React warnings and improve performance. [1] [2]

Copy link
Contributor

@mdorford mdorford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work fine.

Copy link
Contributor

@pmonington pmonington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me and it functions the way it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants