TRITON-???? Allow changing whether firewalls are enabled by default for new VMs through SAPI setting #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, adminui creates all VMs with firewall disabled. Indeed, (IIRC) there are no widgets for enabling a firewall when provisioning though adminui.
In any case, in our use-case we always want the firewall enabled. This patch adds a SAPI setting; when this is enabled, it switches the default. No danger of forgetting then!
Note that this patch does not preclude later adding support for enabling firewalls when provisioning to adminui, since a different default is useful there too.
This has been tested before/after, and is already being used in prod (admittedly only a couple weeks).