ADMINUI-2126 doc development zone in CoaL w/ sdc-admin:master #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
Contributor
There was a problem hiding this comment.
We should be explaining why we are doing something.
Under what circumstances is this step necessary? Always, otherwise sapiadm provision will fail?
Contributor
There was a problem hiding this comment.
Yes, error happens on provision without this step
Contributor
|
These instructions look much better than the previous iteractions, just a few inline questions/comments to sort out. Thank you. |
dan-luk
force-pushed
the
dev-2126-fix
branch
from
8cc35ff to
884ef88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.