Skip to content

Conversation

@Dayuxiaoshui
Copy link
Contributor

Title

Type

  • refactor: (refactor code)

Scope

  • tool: (tools)
    • sdk: (sdk)

Description

Issue: #105

This PR refactors the Python API implementation to address Issue #105:

  • Remove unused code and imports
  • Fix AsyncMiniGU to use asyncio.to_thread for true async operations
  • Improve error handling for PanicException
  • Add comprehensive test cases (29 tests total, increased from 26)
  • Update documentation

Checklist

  • I have prepared the pull request title according to the requirements.
  • I have successfully run all unit tests and integration tests.
  • I have already rebased the latest master branch.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

…-family#105

- Remove unused code and imports
- Fix AsyncMiniGU implementation to use asyncio.to_thread for true async
- Improve error handling for PanicException
- Add comprehensive test cases (29 tests total):
  * Connection management tests
  * Graph operations tests
  * Data loading/saving tests
  * Query execution tests
  * Error handling tests
  * Parameter validation tests
  * Edge cases and boundary conditions tests
- Update Cargo.lock with dependency changes

This refactoring addresses Issue TuGraph-family#105 requirements:
- Removed useless code
- Added missing test cases
- Fixed pseudo-async implementation
@qishipengqsp
Copy link
Collaborator

check the corrupted diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants