-
Notifications
You must be signed in to change notification settings - Fork 123
Nanopb Compiplation Refactor & Protobuf Cleanup #3525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanopb Compiplation Refactor & Protobuf Cleanup #3525
Conversation
williamckha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM very clean! Make sure to update CI so that we don't run ubuntu 22 builds any more
Lmh-java
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legendary work! Left some deep questions.
Lmh-java
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, Github Action scripts should also be changed to address the CI failure.
|
The pre-commit.yml workflow also needs to be upgraded to Ubuntu 24 |
Description
This PR seeks to address the following 3 issues:
nanopb.bzlsetup_software.shto reduce hermiticity issues blocking Add macOS ARM support for Thunderscope #3496 and removed legacy version supporttoolchains_protocTesting Done
deploy_robot_softwareResolved Issues
Resolves #3484
Length Justification and Key Files to Review
nanopb.bzlI've provided documentation on the compile process of this script and how it actually fits into our deploy pipeline. Hopefully this process makes sense now.Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue