Skip to content

Conversation

@Andrewyx
Copy link
Contributor

Description

This PR seeks to address the following 3 issues:

  • Refactor and document the black box nanopb.bzl
  • Audit setup_software.sh to reduce hermiticity issues blocking Add macOS ARM support for Thunderscope #3496 and removed legacy version support
  • Clean up optimization code relating to toolchains_protoc

Testing Done

  • Compilation succeeds for deploy_robot_software
  • Setup software works as previously after deleting unnecessary deps

Resolved Issues

Resolves #3484

Length Justification and Key Files to Review

  • nanopb.bzl I've provided documentation on the compile process of this script and how it actually fits into our deploy pipeline. Hopefully this process makes sense now.

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Copy link
Member

@williamckha williamckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM very clean! Make sure to update CI so that we don't run ubuntu 22 builds any more

Copy link
Contributor

@Lmh-java Lmh-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legendary work! Left some deep questions.

Lmh-java
Lmh-java previously approved these changes Nov 13, 2025
Copy link
Contributor

@Lmh-java Lmh-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, Github Action scripts should also be changed to address the CI failure.

Lmh-java
Lmh-java previously approved these changes Nov 14, 2025
@williamckha
Copy link
Member

The pre-commit.yml workflow also needs to be upgraded to Ubuntu 24

@Andrewyx Andrewyx merged commit 39b34cb into UBC-Thunderbots:master Nov 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor nanopb.bzl and encapsulate similar functionality

3 participants