Redis to TOML refactor #3537
Open
Redis to TOML refactor #3537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieisawesome2
commented
Dec 1, 2025
Contributor
Author
There was a problem hiding this comment.
Not too sure why this file got created.
Member
There was a problem hiding this comment.
Changes to this file are expected (since you updated MODULE.bazel), should be all good
Contributor
|
Your title is backward lol |
Contributor
Author
right i forgot my branch name was backwards RIP |
Andrewyx
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
williamckha
reviewed
Jan 10, 2026
Member
williamckha
left a comment
williamckha
left a comment
There was a problem hiding this comment.
Excellent work! Left a couple comments
Member
There was a problem hiding this comment.
Changes to this file are expected (since you updated MODULE.bazel), should be all good
Member
There was a problem hiding this comment.
We should probably write some tests for this class (chat could probably do a good enough job, we just need some basic test cases as a sanity check).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are transitioning redis to toml for robot constants in this PR.
Testing Done
Ran thunderloop successfully along with connecting to robot and running robot auto test through Ansible.
Resolved Issues
resolves #3315
Length Justification and Key Files to Review
NOTE: Still working on removing redis from workflow.
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue