New release workflow #3566
Open
New release workflow #3566
+197
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_release_workflow
1 task
Added a TODO comment to indicate future MacOS support.
…into new_release_workflow
GrayHoang
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
Andrewyx
requested changes
Jan 19, 2026
Contributor
Andrewyx
left a comment
Andrewyx
left a comment
There was a problem hiding this comment.
Left some feedback. src/software/tar-out/unix_full_system_tar.tar.gz should not be pushed to remote. Looks like some acceptance criteria may be missing, so please remember to refer to the issue specs
Contributor
Author
|
nycrat
approved these changes
Jan 25, 2026
Member
nycrat
left a comment
nycrat
left a comment
There was a problem hiding this comment.
Looks good.
On another note, perhaps it would be beneficial to build for previous macos versions as well? Obviously we can't build for every version but perhaps just some past major versions would work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New release workflow
Testing Done
Resolved Issues
#3554
#3567
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue