RuntimeManager Interface
#3573
Merged
RuntimeManager Interface
#3573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrewyx
requested review from
GrayHoang,
StarrryNight,
a-png129,
adrianchan787,
nycrat and
zuperzane
nycrat
reviewed
Jan 20, 2026
Member
nycrat
left a comment
nycrat
left a comment
There was a problem hiding this comment.
Mostly looks good, but check the failing tests I think you need to include runtime_manager as a dependency for the GL widgets that use it. Otherwise, I would also tag a TODO in the various incomplete classes.
src/software/thunderscope/binary_context_managers/runtime_loader.py
Outdated
Show resolved
Hide resolved
StarrryNight
approved these changes
Jan 21, 2026
Contributor
StarrryNight
left a comment
StarrryNight
left a comment
There was a problem hiding this comment.
Nice work. Looks good to me too.
williamckha
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a partial ticket to help with construction of #3553 by introducing the common singleton interface for each of the subsequent tickets of interest. Additionally constants have been introduced to standardize some of the naming & value schemes.
Required functions have been stubbed out and some helpers have been defined for:
#3572
#3568
#3569
Testing Done
Thunderscope runs as usual.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue