SIM RFC: Clean up runtime installer/loader code #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nycrat
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
nycrat
changed the title
Andrewyx
previously approved these changes
Jan 25, 2026
src/software/thunderscope/binary_context_managers/runtime_installer.py
Outdated
Show resolved
Hide resolved
| if filename.endswith((".tar.gz", ".tgz")): | ||
| with tarfile.open(tmp_path, "r:*") as tar: | ||
| tar.extractall(tmp_dir) | ||
| shutil.move(tmp_dir / extracted_binary_name, dest) |
Contributor
There was a problem hiding this comment.
Does this mean that the version of the release is not attached to this
Member
Author
There was a problem hiding this comment.
Yea the version of the release is not in the unix_full_system binary's name, so we have to extract then rename/move it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some bugs, the integration of everything works now, also some refactoring changes and cleaning up code.
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue