-
Notifications
You must be signed in to change notification settings - Fork 11
User auth #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem like you committed the auto generated sqlx files. They don't need to be included. you can either do drop them by doing a interactive rebase with the '-i' flag, or more simply, just delete them locally then commit the deleted changes. OR you can just drop them on github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the documentation as well for the API. It is in api-server\src\apidocumentation.md
|
@HeisSteve You are talking about the sql files in backend/sqlx correct? |
yep, and also for shared-logic.sqlx as well. |
HeisSteve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this branch to the latest main with git fetch origin main then do git rebase origin main and resolve all the conflicts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do we need this for? seems like it is just for unrelated test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way too many of these auto generated jsons, don't include them in the merge.
Implementation of User Authentication using Argon for password hashing in Rust
Basic APIs are added: creating a user, getting all users, logging in, and deleting a user.