Skip to content

Conversation

@hsn200406
Copy link
Member

Implementation of User Authentication using Argon for password hashing in Rust

Basic APIs are added: creating a user, getting all users, logging in, and deleting a user.

Copy link
Collaborator

@HeisSteve HeisSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem like you committed the auto generated sqlx files. They don't need to be included. you can either do drop them by doing a interactive rebase with the '-i' flag, or more simply, just delete them locally then commit the deleted changes. OR you can just drop them on github

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the documentation as well for the API. It is in api-server\src\apidocumentation.md

@hsn200406
Copy link
Member Author

@HeisSteve You are talking about the sql files in backend/sqlx correct?

@HeisSteve
Copy link
Collaborator

@HeisSteve You are talking about the sql files in backend/sqlx correct?

yep, and also for shared-logic.sqlx as well.

Copy link
Collaborator

@HeisSteve HeisSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this branch to the latest main with git fetch origin main then do git rebase origin main and resolve all the conflicts!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do we need this for? seems like it is just for unrelated test?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way too many of these auto generated jsons, don't include them in the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants