-
Notifications
You must be signed in to change notification settings - Fork 11
Processing Config Filter #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jennyuxi
commented
Jan 11, 2026
- Added processing.ts for reusable default configuration
- Added conditions which change processing config that is sent to backend depending on selections in frontend in filter-node.tsx
- Added code to use the configurations that are sent to backend in useWebsocket.tsx
|
✅ PR approval conditions satisfied (1 lead OR 2 team members approved). |
HeisSteve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the backend side
MaddieWright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you run this locally? It looks like there’s an extra slider being rendered below the node, in addition to the sliders inside combo-box.tsx. Instead of adding a new slider in the FilterNode, you should pass the cutoff state from the FilterNode to the ComboBox via props (lowCutoff, highCutoff, setLowCutoff, setHighCutoff) and let the ComboBox handle all sliders.
Also, the current setup does not account for the bandpass filter configuration. So you could also update for that now. Just a refresher that this is what the backend expects:
- Lowpass - l_freq: null, h_freq: highCutoff
- Highpass - l_freq: lowCutoff, h_freq: null
- Bandpass - l_freq: lowCutoff, h_freq: highCutoff
MaddieWright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, will ask team to test out when building off of it for new tasks