Skip to content

Conversation

@jennyuxi
Copy link

  • Added processing.ts for reusable default configuration
  • Added conditions which change processing config that is sent to backend depending on selections in frontend in filter-node.tsx
  • Added code to use the configurations that are sent to backend in useWebsocket.tsx

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

✅ PR approval conditions satisfied (1 lead OR 2 team members approved).
[Last checked: 2026-02-10T21:28:30.772Z]

HeisSteve
HeisSteve previously approved these changes Feb 2, 2026
Copy link
Collaborator

@HeisSteve HeisSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the backend side

@github-actions github-actions bot requested a review from HeisSteve February 2, 2026 01:21
Copy link
Collaborator

@MaddieWright MaddieWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run this locally? It looks like there’s an extra slider being rendered below the node, in addition to the sliders inside combo-box.tsx. Instead of adding a new slider in the FilterNode, you should pass the cutoff state from the FilterNode to the ComboBox via props (lowCutoff, highCutoff, setLowCutoff, setHighCutoff) and let the ComboBox handle all sliders.

Also, the current setup does not account for the bandpass filter configuration. So you could also update for that now. Just a refresher that this is what the backend expects:

  • Lowpass - l_freq: null, h_freq: highCutoff
  • Highpass - l_freq: lowCutoff, h_freq: null
  • Bandpass - l_freq: lowCutoff, h_freq: highCutoff

Copy link
Collaborator

@MaddieWright MaddieWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, will ask team to test out when building off of it for new tasks

@HeisSteve HeisSteve changed the title Processing Config Filter Processing Config Filter Feb 10, 2026
@MaddieWright MaddieWright merged commit fff2819 into main Feb 10, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants