Skip to content

Conversation

@jaydenpiao
Copy link
Contributor

Changes Being Made

Purpose of Change:

  • New feature
  • Revision of current feature
  • Fixing current feature
  • Other: _______________________

Here give examples of the changes you've made in this pull request. Include an itemized list if you can.

  • frontend ui component
  • button states change from "Download" -> "Downloading" -> "Use"
  • no functionality
  • takes title as prop

How to Test?

  • i just imported RunnerClip and made a div in MINT-Open-Source/main/app/page.tsx like:
    <div className="p-10"> <RunnerClip title="Python" /> </div>

Screenshots (optional)

Screen.Recording.2024-06-02.at.12.15.55.PM.mov

@jaydenpiao jaydenpiao self-assigned this Jun 2, 2024
Copy link
Contributor

@priyanshumahey priyanshumahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes I'd like to ask for:

  • Obtain the SVG and add that to components/icons/icons and then use that SVG
  • Add use client at the top of this file
  • For the prop type, change ({ title }: { title: string }) to ({ title }: {RunnerCliprops and then create a new type for the props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants