Skip to content

reading of PETSIRD list-mode function #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
KrisThielemans wants to merge 99 commits into
base: master
Choose a base branch
from
Draft

reading of PETSIRD list-mode function #1604

KrisThielemans wants to merge 99 commits into from

Conversation

@KrisThielemans
Copy link
Collaborator

@KrisThielemans KrisThielemans commented Jul 16, 2025

WIP

KrisThielemans and others added 13 commits July 14, 2025 17:54
@KrisThielemans KrisThielemans self-assigned this Jul 16, 2025
NikEfth and others added 16 commits July 16, 2025 11:03
@NikEfth
Important fix in CListModeDataPETSIRD.inl
ba44a95
@NikEfth
* Fixes and interface clean up
0ff78b1
@NikEfth
Removed constructor.
f6de251
@danieldeidda
reading header and extracting scanner info
43febf1
@NikEfth
Fixed registries! :)
12e6f57
@NikEfth
Merge branch 'PETSIRD' of github.com:UCL/STIR into PETSIRD
828817e
@NikEfth
Updates on the interface and CMake
4897222
@NikEfth
Compiles and LInks
ddc06a5
@NikEfth
Finished all the infrastrucure. We can now focus on reading events,
3a4ee34
@danieldeidda
reading header and extracting averag position of each detector
d7a00cc
@NikEfth
Finalizing the Interface with PETSIRD.
32c3144
@NikEfth
Trying to figure out how the scanner looks like.
4b39461
@NikEfth
Create ProjDataInfoBlocksOnCylindricalNoArcCorr from PETSIRD
5499245
@NikEfth
Merge remote-tracking branch 'origin/master' into PETSIRD
d029d0d
@NikEfth
* Clean up the code that creates a Scanner object from PETSRID header…
d00e987 
… information.
@NikEfth
* Stop testing for PETSIRD
d0e46a4
@NikEfth NikEfth marked this pull request as ready for review December 22, 2025 14:34
@NikEfth NikEfth marked this pull request as draft December 23, 2025 08:38
NikEfth added 15 commits December 23, 2025 11:48
@NikEfth
Merge branch 'fix/scatter-clone-memleak' into PETSIRD
360b3df
@NikEfth
Remove PETSIRD submodule and decouple PETSIRD from STIR
4386308 
STIR no longer vendors PETSIRD as a submodule.
PETSIRD integration is expected via an external installation
using find_package(PETSIRD).
@NikEfth
Successfully links to PETSIRD.
fdf4a62
@NikEfth
Finally, STIR->PETSIRD map works as expected.
a9cbff5
@NikEfth
CI file that will build PETSIRD-STIR using GitHub Actions.
ee8b22e
@NikEfth
CI builds PETSIRD
b6f8d7c
@NikEfth
Successfully builds and links against PETSIRD in CI.
0031d23
@NikEfth
Work on tests.
51eeb6c
@NikEfth
pre-commit
ed233bb
@NikEfth
Don't build documentation in CI workflow
51d5c43
@NikEfth
Moved PETISDInfo helpers to detail folder
5d93eca 
Introduced generic tests
@NikEfth
pre-commit
1a20b7d
@NikEfth
Commented out unused variables.
36d9091
@NikEfth
I think I guard against some issues with the PETSIRD header.
315ee3e
@NikEfth
pre-commit
2ef68ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikEfth NikEfth NikEfth left review comments

Copilot code review Copilot Copilot left review comments

Assignees

@KrisThielemans KrisThielemans

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KrisThielemans @NikEfth @danieldeidda