Better error message when reading Interfile projdata #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now has an optional argument to be able to open a stream read/write. - errors if stream is empty after opening
Using open_read_binary for all opening of streams for the binary data. This means that a clear message is written when that file doesn't exist or is empty.
Collaborator
Author
|
This change breaks too many things, in particular wherever we use an empty "template" projdata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading of Interfile projection-data will now write a more explicit warning when the binary file is non-existent or empty improving over the cryptic
WARNING: read_data: error after reading from streamthat we wrote before).