Now importing and correctly calling CreateThumbnailElement on install. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColeDCrawford
added a commit
to Harvard-ATG/YouTubeImport
that referenced
this pull request
Jun 28, 2021
Same as hanging PRs UCSCLibrary#27 and UCSCLibrary#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
Installing the current master branch gives an error:
I could be wrong but it doesn't seem like Omeka is configured to autoload files in the
helpersdirectory for a plugin.This PR just includes the file, and also adds the missing brackets for the call to CreateThumbnailElement.
Take care,
-Adam