Publisher-Subscriber To Exchange Messages Between Different Tasks #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jgerbrandt
previously approved these changes
Jan 4, 2025
| * INCLUDES | ||
| ************************************/ | ||
| #include "PubSubSend.hpp" | ||
| #include "SystemDefines.hpp" |
There was a problem hiding this comment.
This include is also in PubSubSend.hpp like the file above.
| * INCLUDES | ||
| ************************************/ | ||
| #include "PubSubReceive.hpp" | ||
| #include "SystemDefines.hpp" |
There was a problem hiding this comment.
SystemDefines.hpp is included in PubSubReceive.hpp. Does it need to be included twice?
| break; | ||
|
|
||
| case DataBrokerMessageTypes::INVALID: | ||
| [[fallthrough]]; |
There was a problem hiding this comment.
is there a reason that this isn't a break statement?
| while (1) { | ||
| /* Process commands in blocking mode */ | ||
| Command cm; | ||
| bool res = qEvtQueue->ReceiveWait(cm); |
There was a problem hiding this comment.
putting this inside the if statement conditional would match syntax with the equivalent lines in the send task (line 63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.