Optimized GUI for Mini RCU screen. 🚀 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connellr023
commented
Dec 5, 2024
connellr023
commented
- Made the sidebar on the left collapsible and expandable by clicking the SOAR logo. This is to increase the amount of usable space on the smaller screen.
- Added confirmation modals when pressing any of the toggle switches to prevent mistakes from the "fat finger" problem.
Jgerbrandt
requested changes
Dec 7, 2024
| // collapsed and expanded by clicking the soar logo. | ||
| // Additionally, there are confirmation modals | ||
| // when clicking the toggle switches. | ||
| export const miniRcu = writable(true); |
There was a problem hiding this comment.
how are we enabling this? I think it might be best to detect this based on screen size.
Author
There was a problem hiding this comment.
Yea I can make this switch on at a certain screen size once we finalize the decision for which screen we go with.
There was a problem hiding this comment.
Would it also be possible to add dynamic scaling of the side and top bar depending on screen size? Right now the top and side bars are huge on smaller screens.
Author
There was a problem hiding this comment.
The side bar can be collapsed by pressing the SOAR logo in this PR. We can certainly make the top bar scale dynamically as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.