Skip to content

HTML validation #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dmnisson wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

HTML validation #577

dmnisson wants to merge 18 commits into from

Conversation

@dmnisson
Copy link
Contributor

@dmnisson dmnisson commented Nov 20, 2020 •
edited
Loading

Links

Description

  • Install html-validate and html-validate-vue plugins, as well as the html-validate Vue CLI plugin
  • Using valid HTML will improve cross-browser compatibility and accessibility
  • Validation-related changes in this PR include adding type attributes to buttons, alt text to some images, and using legend inside of fieldset for the reference form

Developer self-review checklist

  • Potentially confusing code has been explained with comments
  • No warnings or errors have been introduced; all known error cases have been handled
  • Any appropriate documentation (within the code, README.md, docs, etc) has been updated
  • All edge cases have been addressed

@dmnisson
add empty alt text to avatars
d50f60f
@dmnisson
alt text in desktop header logo
b119de6
@dmnisson
add html-validate and html-validate-vue
ab69f26
@dmnisson
install CLI plugin
7e23845
@dmnisson
rollback html-validate to a version that is functional with our curre…
60e7454 
…nt npm version
@dmnisson
remove duplicate class
b0b73cb
@dmnisson
add alt text to session header
12ea683
@dmnisson
remove obsolete button components
c605bbb
@dmnisson
found versions of html-validate and vue-cli-plugin-html-validate that…
9a65337 
… work
@dmnisson
add buttonType prop to custom button components to set type attribute…
e793035 
… on buttons, set appropriate (for now) button types
@dmnisson
fix compile errors and lint
cfacf9d
@dmnisson
remove validator functions for now
948d097
@dmnisson
use legend element; placing instructions outside the fieldset breaks …
f724f63 
…some browser/screen reader combinations
@dmnisson
remove sr-only class and lint
19735b2
@dmnisson
fieldset should always have a legend
fb1280f
@dmnisson
button elements cannot contain divs
1e536ef
@dmnisson
move paragraph out of legend
2ec49ac
@dmnisson
lint
0c79779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmnisson