Adjust default build options #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GPS logging feature is for a specialized use case. Building with the HAVE_GPS option enabled has been found to introduce anomalies in log output during basic usage of MGEN as part of larger-scale tests. This is in addition to presenting the user with errors at startup and outputting "INVALID" in fields in the log file. Users who need this functionality should re-build MGEN with this option enabled. The "clone" command is also for a specialized use case. It introduces a dependency on libpcap, making it significantly less portable, since the only other dependency is the C standard library. MGEN should also be re-built with the HAVE_PCAP option enabled by users who need it.
Collaborator
|
Hi David,
These are good comments and as been a recurring issue both with the libpcap
build issues and the 'warning' message regarding the GPS feature (which
also needs to be updated to support compatibility with gpsd). We will
incorporate this.
…On Sun, Nov 23, 2025 at 11:24 AM David Ward ***@***.***> wrote:
The GPS logging feature is for a specialized use case. Building with the
HAVE_GPS option enabled has been found to introduce anomalies in log
output during basic usage of MGEN as part of larger-scale tests. This is in
addition to presenting the user with errors at startup and outputting
"INVALID" in fields in the log file. Users who need this functionality
should re-build MGEN with this option enabled.
The "clone" command is also for a specialized use case. It introduces a
dependency on libpcap, making it significantly less portable, since the
only other dependency is the C standard library. MGEN should also be
re-built with the HAVE_PCAP option enabled by users who need it.
------------------------------
You can view, comment on, or merge this pull request online at:
#67
Commit Summary
- bbb08d8
<bbb08d8>
Remove HAVE_GPS and HAVE_PCAP from default CFLAGS when building
File Changes
(3 files <https://github.com/USNavalResearchLaboratory/mgen/pull/67/files>
)
- *M* makefiles/Makefile.common
<https://github.com/USNavalResearchLaboratory/mgen/pull/67/files#diff-3d2ceb33e0b368b59c5c4810416b8306279e50eb91f899a733c669fc44847e4b>
(8)
- *M* makefiles/Makefile.linux
<https://github.com/USNavalResearchLaboratory/mgen/pull/67/files#diff-60be1e144d92574262196ad93d981f04f107b751326fd3d15211099152798e62>
(4)
- *M* makefiles/Makefile.macosx
<https://github.com/USNavalResearchLaboratory/mgen/pull/67/files#diff-c466b7502eab0b046f7771df6b81afb245dcc110d4c426e02cb2efe2f201413e>
(17)
Patch Links:
- https://github.com/USNavalResearchLaboratory/mgen/pull/67.patch
- https://github.com/USNavalResearchLaboratory/mgen/pull/67.diff
—
Reply to this email directly, view it on GitHub
<#67>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABU46GIPQDDCZLGYQ564XOL36HNUDAVCNFSM6AAAAACM6QJGS6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGY2TMMJZHE2DAMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Brian Adamson
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPS logging feature is for a specialized use case. Building with the
HAVE_GPSoption enabled has been found to introduce anomalies in log output during basic usage of MGEN as part of larger-scale tests. This is in addition to presenting the user with errors at startup and outputting "INVALID" in fields in the log file. Users who need this functionality should re-build MGEN with this option enabled.The "clone" command is also for a specialized use case. It introduces a dependency on libpcap, making it significantly less portable, since the only other dependency is the C standard library. MGEN should also be re-built with the
HAVE_PCAPoption enabled by users who need it.