convert csfm states to enum #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tandr3w
force-pushed
the
andrew-enum-refactor
branch
6 times, most recently
from
7c1f16f to
9b16a96
Compare
Comment on lines
+7
to
+8
| CORE_SRC := $(shell find $(BASE_INCLUDE_DIR)src/packages -name "*.sv" -o -name "*.v") \ | ||
| $(shell find $(BASE_INCLUDE_DIR)src \( -name "*.sv" -o -name "*.v" \) -not -path "$(BASE_INCLUDE_DIR)src/packages/*") |
Member
There was a problem hiding this comment.
why do we need the packages to be included separately here? im pretty sure it should work without any explicit mentions of the subdirectories as long as its within src/, might be missing smth tho
Author
There was a problem hiding this comment.
I think the packages have to be compiled before the other files, otherwise I get an error like "Reference to 'state_t' before declaration"
tandr3w
force-pushed
the
andrew-enum-refactor
branch
2 times, most recently
from
600abd6 to
afc1716
Compare
tandr3w
force-pushed
the
andrew-enum-refactor
branch
from
afc1716 to
a92eca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #86
Rewrote parameters as an enum and moved it to types.svh (had to change the testbenches to access the state encodings directly).