Eric Chen onboarding #275
Open
Eric Chen onboarding #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dechair3
reviewed
Jan 22, 2026
| HAL_GPIO_WritePin(GPIOB, GPIO_PIN_8, GPIO_PIN_RESET); // lower CS | ||
|
|
||
| uint8_t txData[3] = {0x01, 0x80, 0x00}; // transmit 00000001 start; 1000 0000 single-end, d1-3 =0; whatever | ||
| uint8_t rxData[3] = {0};//receive, 1. null, 2.first 2 digits, 3. rest 8 digits |
There was a problem hiding this comment.
do these arrays need to be inside the loop?
dechair3
reviewed
Jan 22, 2026
|
|
||
| uint16_t result = ((rxData[1] & 0x03) << 8) | rxData[2]; | ||
|
|
||
| printf("ADC value = %d\n", result); |
There was a problem hiding this comment.
Not really a serious mistake but printf wouldn't work on the stm32
dechair3
reviewed
Jan 22, 2026
| TIM1.Channel-PWM\ Generation1\ CH1=TIM_CHANNEL_1 | ||
| TIM1.IPParameters=Channel-PWM Generation1 CH1,Prescaler,Period | ||
| TIM1.Period=20000 | ||
| TIM1.Prescaler=47 |
There was a problem hiding this comment.
There's more optimal parameters you can set for the timer
dechair3
reviewed
Jan 22, 2026
| MX_TIM1_Init(); | ||
| /* USER CODE BEGIN 2 */ | ||
|
|
||
| /* USER CODE END 2 */ |
There was a problem hiding this comment.
There's a function you should invoke to start the timer peripheral before your main loop runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.