Conversation
…quest to Mainz/LaMEM
(to incorporate merge of phase-transition-fixes)
sgeotech
reviewed
Oct 30, 2025
Collaborator
There was a problem hiding this comment.
- DA_CELL_2D_tave and DA_CELL_1D should be moved into dyke structure, since they are only used there
- Math calls like exp, atan, pow, fabs, etc should be replaced with PETSc equivalents for consistency
- periodic BC (I'm working on now) would probably require explicit implementations in dyke codes. In case that it's not needed, we can include a check that would restrict their combination
…abs, cos, sin, exp, sqrt, etc with Petsc math functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated dike.cpp, t26_Dike/dyndike_4core test and lamem_input.dat