[v9] Pinメッセージ機能の実装 by Aqua-218 · Pull Request #229 · UniPro-tech/UniBot

Aqua-218 · 2026-01-28T12:34:56Z

Overview

Pin機能の実装

Issue

Copilot

Pull request overview

This PR implements a Pin feature for a Discord bot, allowing users to pin messages that will be automatically reposted when new messages arrive in the channel. The implementation adds three commands: /pin (via modal), /unpin, and a message context menu option to pin selected messages.

Changes:

Added pin command infrastructure with modal-based and context menu-based pinning
Implemented automatic message resending when new messages arrive in channels with pinned content
Added database operations for managing pin settings per channel

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 16 comments.

Show a summary per file

File	Description
src/internal/repository/pin_setting.go	Adds DeleteByChannelID method to support unpinning by channel
src/internal/bot/handler/messageCreate.go	Implements automatic resending of pinned messages on new message events
src/internal/bot/handler/interaction.go	Adds modal submit handling for pin feature
src/internal/bot/command/registry.go	Registers pin, unpin, and pin select commands
src/internal/bot/command/general/pin.go	Implements /pin command with modal interface and permission checks
src/internal/bot/command/general/unpin.go	Implements /unpin command to remove pinned messages
src/internal/bot/command/general/pin_select.go	Implements message context menu for pinning selected messages
src/internal/bot/command/general/pin_modal.go	Handles modal submission for pin command
src/internal/bot/command/commands.go	Registers command contexts for pin-related commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/internal/bot/command/commands.go

Copilot · 2026-01-28T12:41:20Z

src/internal/bot/handler/messageCreate.go

+	// 自分のピン留めメッセージの場合は無視
+	if r.Author != nil && r.Author.ID == s.State.User.ID {
+		if len(r.Embeds) == 0 {
+			return
+		}
+		if r.Embeds[0].Footer != nil && strings.Contains(r.Embeds[0].Footer.Text, "Pinned Message") {
+			return
+		}


The check for bot's own messages is incomplete. When r.Author is nil (which can happen in certain edge cases), the code will skip the embed check and proceed to resend the pinned message. This could cause the bot to enter an infinite loop where it keeps deleting and resending its own pinned messages. Move the bot check to be a top-level check before line 91, similar to the pattern at lines 26-29.

Suggested change

// 自分のピン留めメッセージの場合は無視

if r.Author != nil && r.Author.ID == s.State.User.ID {

if len(r.Embeds) == 0 {

return

}

if r.Embeds[0].Footer != nil && strings.Contains(r.Embeds[0].Footer.Text, "Pinned Message") {

return

}

// 自分のメッセージや Author が存在しないメッセージの場合は無視

if r.Author == nil || r.Author.ID == s.State.User.ID {

return

src/internal/bot/command/general/pin_modal.go

Copilot · 2026-01-28T12:41:21Z

src/internal/bot/command/general/pin_modal.go

+	repo := repository.NewPinSettingRepository(ctx.DB)
+	setting := &model.PinSetting{
+		ID:        i.ChannelID,
+		URL:       sentMessage.ID,
+		Title:     "Pinned Message",
+		Content:   message,
+		GuildID:   i.GuildID,
+		ChannelID: i.ChannelID,
+	}
+
+	if err := repo.Update(setting); err != nil {
+		if err := repo.Create(setting); err != nil {
+			replyPinError(s, i, config, "エラー", "ピン留めの保存に失敗しました。")
+			return true
+		}
+	}


The pin modal handler does not check if a pinned message already exists in the channel, unlike the PinSelect function which properly validates this at lines 61-64 in pin_select.go. This inconsistency means that using the modal via /pin command could overwrite existing pins without warning, while using the message context menu will reject the operation. Consider adding the same check here: query for existing settings and either reject with an error message or explicitly handle the overwrite case.

Copilot · 2026-01-28T12:41:21Z

src/internal/bot/command/general/pin_select.go

+	sentMessage, err := s.ChannelMessageSendEmbed(i.ChannelID, embed)
+	if err != nil {
+		replyPinError(s, i, config, "エラー", "メッセージの送信に失敗しました。")
+		return
+	}
+
+	setting := &model.PinSetting{
+		ID:        i.ChannelID,
+		URL:       sentMessage.ID,
+		Title:     "Pinned Message",
+		Content:   targetMsg.Content,
+		GuildID:   i.GuildID,
+		ChannelID: i.ChannelID,
+	}
+
+	err = repo.Create(setting)
+	if err != nil {
+		replyPinError(s, i, config, "エラー", "ピン留めの保存に失敗しました。")
+		return
+	}


In the pin message context menu handler, after successfully pinning a message, there is no cleanup of the old pinned message if one exists. Unlike the modal handler and resendPinnedMessage function, this code doesn't check for or delete existing pinned messages before creating a new one. This is inconsistent with the error check at lines 61-64 which prevents creating a second pin. If that check were ever removed or if there's a race condition, this could result in multiple pinned messages accumulating in the channel. Consider deleting the old pinned message if settings already exist before the check at line 61.

Copilot · 2026-01-28T12:41:23Z

src/internal/bot/command/general/pin_modal.go

+
+func replyPinSuccess(s *discordgo.Session, i *discordgo.InteractionCreate, config *internal.Config, title string) {
+	_ = s.InteractionRespond(i.Interaction, &discordgo.InteractionResponse{
+		Type: discordgo.InteractionResponseChannelMessageWithSource,
+		Data: &discordgo.InteractionResponseData{
+			Embeds: []*discordgo.MessageEmbed{
+				{
+					Title:     title,
+					Color:     config.Colors.Success,
+					Timestamp: time.Now().Format(time.RFC3339),
+				},
+			},
+			Flags: discordgo.MessageFlagsEphemeral,
+		},
+	})
+}


The replyPinSuccess function is defined but never used anywhere in the codebase. Consider removing this unused function to reduce code clutter and maintenance burden.

Suggested change

func replyPinSuccess(s *discordgo.Session, i *discordgo.InteractionCreate, config *internal.Config, title string) {

_ = s.InteractionRespond(i.Interaction, &discordgo.InteractionResponse{

Type: discordgo.InteractionResponseChannelMessageWithSource,

Data: &discordgo.InteractionResponseData{

Embeds: []*discordgo.MessageEmbed{

{

Title: title,

Color: config.Colors.Success,

Timestamp: time.Now().Format(time.RFC3339),

},

},

Flags: discordgo.MessageFlagsEphemeral,

},

})

}

Copilot · 2026-01-28T12:41:23Z

src/internal/bot/command/general/pin.go

+						CustomID:    "message",
+						Label:       "投稿内容",
+						Style:       discordgo.TextInputParagraph,
+						Placeholder: "投稿内容を入力してください。すでにPinされたメッセージがある場合は上書きされます。",


The modal placeholder text states "すでにPinされたメッセージがある場合は上書きされます" (existing pinned messages will be overwritten), but this contradicts the actual behavior in pin_select.go (lines 61-64) which prevents pinning when a message already exists. This discrepancy in the user-facing message creates confusion about the expected behavior. Ensure the placeholder text accurately reflects the actual implementation, or align the implementation with this stated behavior by allowing overwrites.

src/internal/bot/command/general/pin_modal.go

Copilot · 2026-01-28T12:41:24Z

src/internal/bot/command/general/unpin.go

+	err = repo.DeleteByChannelID(i.ChannelID)
+	if err != nil {
+		replyPinError(s, i, config, "エラーが発生しました", "ピン留めの解除中にエラーが発生しました。")
+		return
+	}


The unpin command deletes the pin setting from the database but does not delete the actual pinned message from the Discord channel. Users will see the pinned message remain in the channel even after unpinning. Before deleting from the database (line 49), iterate through the settings and delete each message using s.ChannelMessageDelete(i.ChannelID, setting.URL) to clean up the Discord channel as well.

Copilot · 2026-01-28T12:41:24Z

src/internal/repository/pin_setting.go

+func (r *PinSettingRepository) DeleteByChannelID(channelID string) error {
+	return r.db.Delete(&model.PinSetting{}, "channel_id = ?", channelID).Error
+}


The newly added DeleteByChannelID method lacks test coverage. The repository test file (pin_setting_test.go) contains comprehensive tests for other methods but does not test this new functionality. Add test cases to verify that DeleteByChannelID correctly deletes all pin settings for a given channel ID, preserves settings for other channels, and handles non-existent channel IDs appropriately.

yuito-it

外部キー制約でエラーですね

2026/01/29 19:48:47 /Users/yutaka/Documents/Dev/UniProject/UniBot/src/internal/repository/pin_setting.go:24 ERROR: insert or update on table "pin_settings" violates foreign key constraint "fk_pin_settings_guild" (SQLSTATE 23503)
[21.482ms] [rows:0] INSERT INTO "pin_settings" ("id","url","title","content","guild_id","channel_id","created_at","updated_at") VALUES ('1383480147080118345','1466384575231164531','Pinned Message','test','1383480145486286879','1383480147080118345',1769683727144787000,1769683727144787000)

yuito-it

LGTM!と言いたいところですが...
pin_modalとpin_selectで既存のpin留めがある場合の挙動が異なります。
pin_modalでも警告を出すように統一する方が望ましいと思います。

yuito-it · 2026-01-31T01:49:33Z

@Aqua-218 ...

yutaka@IM092985 src % ../scripts/build.sh --dev            
# unibot/internal/bot/command
internal/bot/command/commands.go:18:10: undefined: general.LoadScheduleCommandContext
internal/bot/command/registry.go:17:35: undefined: general.Schedule

yuito-it

#225 と同じく、返却はEditで行う必要があります。
また、 @copilot のレビューを解決してください。

Aqua-218 requested a review from a team as a code owner January 28, 2026 12:34

Copilot AI review requested due to automatic review settings January 28, 2026 12:34

Copilot started reviewing on behalf of Aqua-218 January 28, 2026 12:35 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

yuito-it added the kind/feature 新機能のリクエスト label Jan 28, 2026

yuito-it added this to UniBot Feature Relase Jan 28, 2026

github-project-automation bot moved this to Untouched in UniBot Feature Relase Jan 28, 2026

yuito-it assigned Aqua-218 Jan 28, 2026

yuito-it added this to the v9 - Go Edition milestone Jan 28, 2026

yuito-it linked an issue Jan 28, 2026 that may be closed by this pull request

[v9] Pin メッセージ #213

Open

yuito-it moved this from Untouched to In Review in UniBot Feature Relase Jan 28, 2026

yuito-it changed the title ~~Feat/go pin~~ [v9] Pinメッセージ機能の実装 Jan 28, 2026

yuito-it requested changes Jan 29, 2026

View reviewed changes

github-project-automation bot moved this from In Review to In Progress in UniBot Feature Relase Jan 29, 2026

yuito-it requested changes Jan 29, 2026

View reviewed changes

Aqua-218 requested a review from a team as a code owner January 29, 2026 15:21

Aqua-218 requested review from ibuki-hum4 and removed request for a team January 29, 2026 15:21

yuito-it removed this from UniBot Feature Relase Jan 29, 2026

yuito-it requested review from yuito-it and removed request for ibuki-hum4 January 31, 2026 01:48

Aqua-218 added 8 commits January 31, 2026 18:30

pinコマンド追加

68e6a11

unpinコマンド追加

20b306a

pin選択コマンド追加

f08166b

pinモーダル追加

7f22aa5

pin設定削除追加

1a79682

pinモーダル受付

38f9e5b

pin再送処理

142ccea

pinコマンド登録

fcf63e8

Aqua-218 added 6 commits January 31, 2026 18:30

pinハンドラ登録

5def9fb

pinコマンドからスケジュール機能を削除し、ピンエラー応答にリクエスト者情報を追加

b7bb442

PinSettingの作成と更新時にギルドの存在を確認する処理を追加

162fc71

pinハンドラ登録

ab2214a

ピン留め処理の改善: 既存のピン留めメッセージを確認し、エラーハンドリングを追加

b03263e

schedule登録削除

e27125e

yuito-it force-pushed the feat/go-pin branch from 78f92cb to e27125e Compare January 31, 2026 09:31

yuito-it requested changes Feb 2, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 2, 2026

[WIP] Update to address feedback on Edit return requirement for Pin Message #240

Closed

13 tasks

UniPro-tech deleted a comment from Copilot AI Feb 2, 2026

ピン留めおよびアンピン処理の応答をInteractionResponseEditに変更し、エラーメッセージの表示を改善

e07045d

Conversation

Aqua-218 commented Jan 28, 2026

Overview

Issue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

yuito-it left a comment

Choose a reason for hiding this comment

Uh oh!

yuito-it left a comment

Choose a reason for hiding this comment

Uh oh!

yuito-it commented Jan 31, 2026

Uh oh!

yuito-it left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants