Conversation
for better reading experience
feat(dark-mode): implement basic dark mode
… when press enter note that click on submit button will emit a onsubmit event re #21
inherit the root color of checkbox
maybe we should use formatter tools and lint tools
feat: Press enter to login
feat(dark-mode): override the checked checkbox styles
I tried my best to remain current code style, and not using eslint since CRA include it as default re #19
make IconButton visiable under dark mode
dont allow admin to unset admin, self tested well
feat(set-admin): implement set admin
winderica
requested review from
ManiaciaChao,
colinaaa,
ttzztztz and
wangnengjie
Contributor
|
on "在秋招/春招/夏令营时间段，日常招新是否有效": |
Contributor
@ManiaciaChao ，这次要做选手dashboard的话，可以让PM那边考虑一下流程？目前日常招新对内只是个提议，对外尚没有什么说法。 |
Contributor
|
英文的话，感觉我们的“normal”是秋招春招，反而“日常招新”是计划外的。unscheduled 或者 flexible 可能更符合语义？ @wangnengjie |
ManiaciaChao
approved these changes
Nov 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
待讨论的问题：
联动：