VPS-178/conditional-resources #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinchen8
force-pushed
the
VPS-178/conditional-resources
branch
from
4e51c52 to
036990c
Compare
harbassan
approved these changes
Oct 23, 2025
Contributor
harbassan
left a comment
harbassan
left a comment
There was a problem hiding this comment.
nice, lgtm, tested and it seems to work well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
No functionality to conditionally load resources on state variables.
Describe the solution
Make resources load conditionally.
Risk
There are existing bugs with changing state variables which cause resources to render incorrectly.
Definition of Done
Reviewed By
Who reviewed your PR - for commit history once merged