Dashboard access #338
Merged
Dashboard access #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Front] Crudhook: - Updated to check if mounted before setting stuff and retrying to avoid errors in console (this could break other stuff but it really shouldn't) [Front] ScenarioSelectionPage(home): - Added ability to receive toast notifications [Front] Dashboard: - Updated the API endpoints the page hits for data and added a check to avoid hitting endpoints multiple times just for it to be unauthorized - Cleaned up unused code in viewgroup. [Back] Dashboard API: - Added middleware auth to endpoints - Updated the dashboardAuth middleware to support the viewgroup page
CrudHooks: - Updated useGet to set a response that the application and interact with instead of just the data
Now supports old scenarios. Legacy scenarios created without an AccessList, the owner is now the only person that should be able to access it.
[Backend] Access Schema - Updated access schema to store more info on user that has access Access API - Added and updated endpoints AccessDao - Updated for better funtionality Dashboard Auth - Refactor [Frontend] Access Table - Created a temp access table where you can search for users who have access and delete users from being able to access. Deleting currently works if they are on the table but no way to add a user (WIP). [Packages] +TanStack react table (access table) + React select for adding users (WIP)
[Dashboard Auth] - Added owner check for create/delete stuff using scenario auth [Misc] - Prettier + lint front/back end
harbassan
approved these changes
Nov 18, 2025
Contributor
harbassan
left a comment
harbassan
left a comment
There was a problem hiding this comment.
approving without comprehensive testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
Anyone could access the dashboard page of any scenario.
Dashboard tables needed restyling to fit the existing theme
Describe the solution
Read all my commit messages all changes outlined in detail in the commits
Risk
Maybe lots of things? 😅 jk maybe 1 or 2
Crud hook could break, made some changes but it shouldn't
Definition of Done
Reviewed By
Who reviewed your PR - for commit history once merged