listen to conversation agent additions in chat#805
Open
AbdurrehmanSubhani wants to merge 2 commits intodevfrom
Open
listen to conversation agent additions in chat#805AbdurrehmanSubhani wants to merge 2 commits intodevfrom
AbdurrehmanSubhani wants to merge 2 commits intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avaer
reviewed
Dec 22, 2024
| }); | ||
|
|
||
| const agentSpecs = agents | ||
| .filter(mapAgent => mapAgent.playerId !== agent.id) |
Contributor
There was a problem hiding this comment.
We don't want the current agent in this list?
Contributor
Author
There was a problem hiding this comment.
The current agent is being added via the currentAgentSpec + formatAgent inside the Prompt component, agentSpecs mapped out for "Other Characters" hence need to exclude the current agent
avaer
reviewed
Dec 22, 2024
| } | ||
| addAgent(agentId: string, player: Player) { | ||
| this.agentsMap.set(agentId, player); | ||
| this.dispatchEvent(new Event('addAgent')); |
Contributor
There was a problem hiding this comment.
Recommend rename to 'agentschange'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.