This repository was archived by the owner on Oct 20, 2022. It is now read-only.
Open
Conversation
keiranjprice101
requested review from
a team and
vyshnavi1605
and removed request for
a team
jekabs-karklins
approved these changes
Jun 1, 2022
ACLay
reviewed
Jun 1, 2022
Contributor
ACLay
left a comment
ACLay
left a comment
There was a problem hiding this comment.
Maybe it's just a lack of familiarity with the project/structure, but I can't figure out where or how this script is called or used. Could you give me a quick run through? Would that be worth adding as comments at the start of the script?
| } | ||
|
|
||
| main(); | ||
| main().catch((e) => console.error(e)); |
Contributor
There was a problem hiding this comment.
There's a couple of other promise .catch methods that call console.log Should they be changed to error too?
Contributor
Author
|
@ACLay The intention is for this script and the delete template script to be run periodically by jenkins to keep dev and prod templates in sync. That is why its not called anywhere else. I will add a comment to make this more clear 👍 |
ACLay
approved these changes
Jun 1, 2022
vyshnavi1605
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issues with the template import script and makes logging clearer.
Requires UserOfficeProject/user-office-backend#666
Motivation and Context
I previously had only properly checked the delete script and failed to properly check the importScript this now works as expected.
How Has This Been Tested
Manual Testing
Fixes
Changes
Depends on
Tests included/Docs Updated?