Conversation
|
Thank you for working on this, @moontrip. I think this approach seems reasonable, but it will require some UX discussion. Also, we don't want to hard code DOM element IDs, as it creates an implicit coupling between the legend implementation and the I noticed that the associated issue is still in "Needs triage". I'm not sure this is considered urgent, at the moment. However, I think this PR serves as a good proof-of-concept. Perhaps a future iteration would be to pass an array of objects (maybe specifying DOM refs and file names) to |
|
@dmfalke Thank you for your review and comments 👍 Yes as this PR is draft, I just wanted to test if it would work, without considering it too much: in part, I wanted to find something to do😅 Not quite sure if we will ever do it but yes it can be served as a proof-of-concept at least 😄 |
Hi @dmfalke This is an attempt to possibly address #946, especially based on the last/latest comment, #946 (comment).
I have tried many ways, even trying to use html-to-image, which is a forked version of the dom-to-image and more updated library, but realized that dom-to-image was already installed and worked just fine for our purpose so I sticked to it. There were several issues but I could manage to find ways. From my various tests, this seems to work as intended, but just in case, I made this as a draft PR as there may be a better way 🤔