Draft
Conversation
dmfalke
reviewed
Nov 8, 2024
Contributor
dmfalke
left a comment
dmfalke
left a comment
There was a problem hiding this comment.
Looking good! I made a comment :)
| // Could use wdk usePromise? or react-query? | ||
| useEffect(() => { | ||
| // Fetch the config JSON | ||
| fetch('/jbrowse2/config.json') |
Contributor
There was a problem hiding this comment.
Ideally, this would be a configuration value that gets set in configer. Something like jbrowse2_root_url = /jbrowse2. Then, you can update __SITE_CONFIG__ in EbrcWebsiteCommon/Model/lib/conifer/roles/conifer/templates/EbrcWebsiteCommon/appBase.html.j2 to include that value. Then, update packages/libs/web-common/src/config.ts to export that value. Finally, you can import that here via import { jbrowse2RootUrl } from 'web-common/lib/config';.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You will need this in your
genomics-site/.env