Feature 1382 one network viz to rule them all#1497
Draft
Conversation
Member
Author
|
This PR is in limbo because it depends on some backend work in VEuPathDB/service-eda#93. This work is part of a feature request for wgcna to allow the user to run self-correlation on a wgcna module collection. It's not a showstopper for release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1382
Allows the
correlationcompute plugin to switch its child visualizations based on the parameters.So much simpler than a new network viz (would have required backend work as well).
One network viz isn't out of the question, but it's not a necessity right now, thanks to the notebook. It's also possible we change the current network visualizations to be called "correlation networks" because both are only focused on displaying correlation results. But until we have a network that does something else besides correlation, i'll leave that be :)
Important to note, by taking this strategy of having the notebook determine which viz to use based on the compute we're having the perspective that the notebook knows best. That is, in eda workspace land we try to let the user do whatever they want. But the notebook is getting more and more opinionated.