Skip to content

Comments

Feature 1382 one network viz to rule them all#1497

Draft
asizemore wants to merge 3 commits intomainfrom
feature-1382-one-network-viz-to-rule-them-all
Draft

Feature 1382 one network viz to rule them all#1497
asizemore wants to merge 3 commits intomainfrom
feature-1382-one-network-viz-to-rule-them-all

Conversation

@asizemore
Copy link
Member

Resolves #1382

Allows the correlation compute plugin to switch its child visualizations based on the parameters.

So much simpler than a new network viz (would have required backend work as well).
One network viz isn't out of the question, but it's not a necessity right now, thanks to the notebook. It's also possible we change the current network visualizations to be called "correlation networks" because both are only focused on displaying correlation results. But until we have a network that does something else besides correlation, i'll leave that be :)

Important to note, by taking this strategy of having the notebook determine which viz to use based on the compute we're having the perspective that the notebook knows best. That is, in eda workspace land we try to let the user do whatever they want. But the notebook is getting more and more opinionated.

@asizemore
Copy link
Member Author

This PR is in limbo because it depends on some backend work in VEuPathDB/service-eda#93.

This work is part of a feature request for wgcna to allow the user to run self-correlation on a wgcna module collection. It's not a showstopper for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WGCNA: allow genomics correlation to accept self-correlation inputs

1 participant