Skip to content

Conversation

@stv0g
Copy link
Contributor

@stv0g stv0g commented Jun 20, 2025

Continuation of this comment from the reviewer: openjournals/joss-reviews#8401 (comment)

@stv0g stv0g requested a review from al3xa23 June 20, 2025 09:38
@stv0g stv0g requested a review from n-eiling as a code owner June 20, 2025 09:38
@stv0g stv0g changed the base branch from master to joss June 20, 2025 09:38
@stv0g stv0g changed the title JOSS paper: Proposal for author list [joss] Proposal for author list Jun 20, 2025
@stv0g
Copy link
Contributor Author

stv0g commented Jun 20, 2025

Hi,

We are currently discussing, how we handle/adjust the author list of the JOSS paper in response to the comment by our reviewer: openjournals/joss-reviews#8401 (comment)

I proposed, to adjust it based on contribution to VILLASnode in the form of:

  • Code
  • User support
  • Architectural guidance
  • Documentation

Please feel free to comment or make alternative proposals.

@stv0g stv0g force-pushed the joss-author-list branch from 8ee706c to 52fd213 Compare June 20, 2025 09:50
@n-eiling
Copy link
Member

This is not the order you proposed in the comment on the review, or am I missing something? We could also order the authors alphabetically or random.

@stv0g stv0g force-pushed the joss-author-list branch 2 times, most recently from 6c93a62 to 900c009 Compare June 23, 2025 08:01
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@stv0g stv0g force-pushed the joss-author-list branch from 900c009 to cac2b64 Compare June 23, 2025 08:03
@stv0g
Copy link
Contributor Author

stv0g commented Jun 23, 2025

This is not the order you proposed in the comment on the review, or am I missing something?

Thanks for the note, I fixed the order to match the one suggested in the review comment.

@stv0g
Copy link
Contributor Author

stv0g commented Jun 24, 2025

Hi @al3xa23 and everybody else,

How should we proceed? I would like to see some more feedback and/or approvals for this PR, so we can merge #930 and reply to the JOSS reviewer.

@al3xa23
Copy link
Contributor

al3xa23 commented Jun 24, 2025

From my side, we can merge. No objections

@leonardocarreras
Copy link
Contributor

@stv0g is there any particular reason to fully remove some people from the paper? It looks like you delete many names

@leonardocarreras
Copy link
Contributor

I would like to add that in my specific case, I understand what I did can fit in https://credit.niso.org/contributor-roles/writing-review-editing/ as per the paper. It might happen that other people that were there also played a role (beyond writing code, for example as the review process is a valid reason to be included). I would suggest we need to wait some more days for written feedback from them, as it is also a period of vacations.

@stv0g
Copy link
Contributor Author

stv0g commented Jun 24, 2025

Hi @leonardocarreras,

yes I removed some names as the reviewer questioned the authorship. He made the example for @al3xa23:

The author @al3xa23 is not the major contributor for the repo. They have made 4 commits, in comparison to stv0g who has made close to 4700 commits to the software. The contribution and authorship checklist is not really met, how do we proceed?

But I believe the same also applies to other authors. Or did we miss any significant non-code contribution to VILLASnode?

@leonardocarreras
Copy link
Contributor

I did provide contributions to the text and reviewed the paper in many times on the process. I just suggest that as far as I am aware, the fact that you are not in working at RWTH ACS anymore might give you a partial picture of the state of things. If is just for the count of commits, some included authors have less commits. I still suggest that you can reach us to discuss without unilateral decisions, because it feels kinder and avoids long written text that could interpreted in a wrong way.
If all the rest think that the provided contributions have absolute zero value, then is probably fair.

@n-eiling
Copy link
Member

In my opinion, we should keep all authors. Initiating, preparing, reviewing and pushing the publication is important and should be acknowledged. Sounds to me like the reviewers questioned the ordering of authors and not necessarily the number.

al3xa23 added 2 commits July 9, 2025 10:49
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
@stv0g
Copy link
Contributor Author

stv0g commented Jul 9, 2025

@al3xa23 Thanks for the change. Could you approve the PR, so we can merge it?

Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@stv0g stv0g force-pushed the joss-author-list branch from 501f7f6 to b1ea5d5 Compare July 9, 2025 12:13
@stv0g stv0g merged commit f6fb690 into joss Jul 9, 2025
3 checks passed
@stv0g stv0g deleted the joss-author-list branch July 9, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants