Skip to content

Conversation

@EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 30, 2025


  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Необходимо реализовать компонент Reorder для реализации перетаксивания элементов в вертикальном списке.

Изменения

  • Реализовал компонент Reorder с подкомпонентным подходом
  • Использовал Reorder внутри компонента List и Cell
  • Добавил страницу документации для компонента Reorder
  • Выпилил компонент CellDragger

Release notes

Новые компоненты

  • Reorder: Компонент для реализации перетаскивания элементов в вертикальном списке

@EldarMuhamethanov EldarMuhamethanov self-assigned this Sep 30, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 30, 2025 15:17
@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft September 30, 2025 15:17
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 928ea77

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9014/928ea77b490ad3aafc4d2d7489f9be74f0b6598b/pkg/@vkontakte/vkui/_pkg.tgz

Commit 928ea77

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

size-limit report 📦

Path Size
JS 413.63 KB (+0.41% 🔺)
JS (gzip) 127.05 KB (+0.45% 🔺)
JS (brotli) 104.67 KB (+0.56% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 373.34 KB (+0.02% 🔺)
CSS (gzip) 46.26 KB (+0.02% 🔺)
CSS (brotli) 36.61 KB (+0.09% 🔺)

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.71%. Comparing base (6e3da5e) to head (928ea77).

Files with missing lines Patch % Lines
packages/vkui/src/components/Reorder/Reorder.tsx 80.76% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9014      +/-   ##
==========================================
- Coverage   94.73%   94.71%   -0.02%     
==========================================
  Files         440      445       +5     
  Lines       11898    11954      +56     
  Branches     4386     4397      +11     
==========================================
+ Hits        11271    11322      +51     
- Misses        627      632       +5     
Flag Coverage Δ
unittests 94.71% <93.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review October 2, 2025 09:53
@EldarMuhamethanov EldarMuhamethanov added the no-stale Добавляет PR в исключения для автоматического закрытия label Oct 10, 2025
@inomdzhon inomdzhon added this to VKUI Jan 14, 2026
@inomdzhon inomdzhon moved this to ✅ Done in VKUI Jan 14, 2026
@EldarMuhamethanov EldarMuhamethanov added this to the v8.1.0 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-stale Добавляет PR в исключения для автоматического закрытия

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants