Add missing std::vector reserve calls #7780
Merged
+95
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
More reserve calls being added. performance-inefficient-vector-operation is a very good clang-tidy check for this |
SmoothHacker
force-pushed
the
fix-vector-reserve
branch
from
0b3c9f8 to
53da013
Compare
# Conflicts: # function.cpp
CouleeApps
reviewed
Dec 16, 2025
Member
CouleeApps
left a comment
CouleeApps
left a comment
There was a problem hiding this comment.
LGTM. Probably a mild perf win too, thanks for the contribution
CouleeApps
approved these changes
Dec 16, 2025
CouleeApps
force-pushed
the
fix-vector-reserve
branch
from
53da013 to
6138978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #7702 and adds
vector.reverse()calls in other places